feat(issues): infer project platform if not set #95402

cvxluo · 2025-07-13T04:40:35Z

If a project ends up with no platform (e.g. by API creation), we attempt to infer it from its next event by setting the project's platform to the event's platform.

codecov · 2025-07-13T04:58:01Z

Codecov Report

Attention: Patch coverage is 96.29630% with 1 line in your changes missing coverage. Please review.

✅ All tests successful. No failed tests found.

Files with missing lines	Patch %	Lines
src/sentry/event_manager.py	90.00%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##           master   #95402      +/-   ##
==========================================
- Coverage   87.84%   82.88%   -4.97%     
==========================================
  Files       10502    10457      -45     
  Lines      608126   605810    -2316     
  Branches    23719    23710       -9     
==========================================
- Hits       534228   502133   -32095     
- Misses      73540   103319   +29779     
  Partials      358      358

yuvmen

looks good :), just a minor comment about a comment, might want to let Katie approve as well before you merge

src/sentry/event_manager.py

mrduncan · 2025-07-14T19:52:23Z

src/sentry/event_manager.py

+def _set_project_platform_if_needed(project: Project, event: Event) -> None:
+    # Only infer the platform if it's useful - if the event platform is "other" or null, there's
+    # no useful information for us to set the project platform
+    if not event.platform or event.platform == "other":


We should exclude "other" here, users can explicitly select this during project creation by searching for it and we shouldn't overwrite it:

here, we exclude events without a platform - we won't overwrite platform if it is set anywhere
the motivation to exclude 'other' events is that in cases where an event is missing a platform, it seems to get normalized to 'other'. in those cases, i'd rather ignore the event and do nothing rather than assign the project to 'other'

src/sentry/event_manager.py

wedamija · 2025-07-16T18:45:52Z

src/sentry/event_manager.py

+    if project.platform:
+        return
+
+    if event.platform not in VALID_PLATFORMS or event.get_tag("sample_event") == "yes":
+        return


Nit: Could combine this into the same if

src/sentry/event_manager.py

cursor

Bug: In-memory Project Platform Not Updated Post-Database Write

When a project's platform is inferred and updated in the database, the in-memory project object's platform attribute is not refreshed. This results in stale project.platform data (None or empty string) for subsequent operations within the same request, even though the database has been correctly updated. The fix involves updating the in-memory project.platform attribute after the successful database write.

src/sentry/event_manager.py#L709-L720

sentry/src/sentry/event_manager.py

Lines 709 to 720 in 6f7ee89

    
           try: 
        
               updated = Project.objects.filter( 
        
                   Q(id=project.id) & (Q(platform__isnull=True) | Q(platform="")) 
        
               ).update(platform=event.platform) 
        
               if updated: 
        
                   create_system_audit_entry( 
        
                       organization=project.organization, 
        
                       target_object=project.id, 
        
                       event=audit_log.get_event_id("PROJECT_EDIT"), 
        
                       data={**project.get_audit_log_data(), "platform": event.platform}, 
        
                   )

Fix in Cursor • Fix in Web

Was this report helpful? Give feedback by reacting with 👍 or 👎

lobsterkatie and others added 2 commits July 11, 2025 14:04

add helper to set project platform

36b63c7

infer project platform if not set

88faf1b

github-actions bot added the Scope: Backend Automatically applied to PRs that change backend components label Jul 13, 2025

cvxluo added 2 commits July 13, 2025 09:16

stop inferring project if changed manually

6fb23e5

fix tests

afc8907

vercel bot deployed to Preview July 13, 2025 18:23 View deployment

handle 'other' events

c559e38

vercel bot deployed to Preview July 13, 2025 21:32 View deployment

clean up typos + tests

2d2ec4d

vercel bot deployed to Preview July 13, 2025 21:36 View deployment

Merge branch 'master' into cvxluo/infer-project-platform

c7c5a2a

vercel bot deployed to Preview July 13, 2025 22:44 View deployment

cvxluo marked this pull request as ready for review July 14, 2025 02:19

cvxluo requested a review from a team as a code owner July 14, 2025 02:19

This comment was marked as outdated.

Sign in to view

add lock + atomic transaction

05c536d

vercel bot deployed to Preview July 14, 2025 03:47 View deployment

yuvmen approved these changes Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

cvxluo requested a review from lobsterkatie July 14, 2025 18:49

scttcper reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

mrduncan reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

mrduncan reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

lobsterkatie reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

lobsterkatie reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

stop inferring to 'other' + options gating + filter out sample events

597b3c4

vercel bot deployed to Preview July 14, 2025 20:59 View deployment

This comment was marked as outdated.

Sign in to view

clean up option key

9bfc4ba

wedamija reviewed Jul 14, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

src/sentry/event_manager.py Outdated Show resolved Hide resolved

cvxluo added 2 commits July 14, 2025 17:09

use queryset update instead of transaction

1e25c0a

use VALID_PLATFORMS instead of ad-hoc event platform filtering

b0e8ec8

vercel bot deployed to Preview July 15, 2025 00:13 View deployment

save changes

26c7fe3

vercel bot deployed to Preview July 15, 2025 00:20 View deployment

This comment was marked as outdated.

Sign in to view

better filtering

7bde68e

vercel bot deployed to Preview July 15, 2025 18:01 View deployment

This comment was marked as outdated.

Sign in to view

fix query

054c0b2

cvxluo force-pushed the cvxluo/infer-project-platform branch from 76d0cda to 054c0b2 Compare July 15, 2025 19:07

vercel bot deployed to Preview July 15, 2025 19:09 View deployment

This comment was marked as outdated.

Sign in to view

fix comment

89d40a7

vercel bot deployed to Preview July 15, 2025 19:57 View deployment

This comment was marked as outdated.

Sign in to view

cvxluo requested a review from a team July 15, 2025 23:28

wedamija reviewed Jul 16, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

src/sentry/event_manager.py Outdated Show resolved Hide resolved

src/sentry/event_manager.py Outdated Show resolved Hide resolved

remove extra lock + cache

553895b

vercel bot deployed to Preview July 16, 2025 17:50 View deployment

This comment was marked as outdated.

Sign in to view

wedamija approved these changes Jul 16, 2025

View reviewed changes

wedamija reviewed Jul 16, 2025

View reviewed changes

src/sentry/event_manager.py Outdated Show resolved Hide resolved

wedamija approved these changes Jul 16, 2025

View reviewed changes

try except

6f7ee89

vercel bot deployed to Preview July 16, 2025 19:48 View deployment

cursor bot reviewed Jul 16, 2025

View reviewed changes

cvxluo merged commit 975b000 into master Jul 16, 2025
64 checks passed

cvxluo deleted the cvxluo/infer-project-platform branch July 16, 2025 20:04

	try:
	updated = Project.objects.filter(
	Q(id=project.id) & (Q(platform__isnull=True) \| Q(platform=""))
	).update(platform=event.platform)

	if updated:
	create_system_audit_entry(
	organization=project.organization,
	target_object=project.id,
	event=audit_log.get_event_id("PROJECT_EDIT"),
	data={**project.get_audit_log_data(), "platform": event.platform},
	)

Uh oh!

feat(issues): infer project platform if not set #95402

feat(issues): infer project platform if not set #95402

Conversation

cvxluo commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

codecov bot commented Jul 13, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

This comment was marked as outdated.

Uh oh!

yuvmen left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

mrduncan Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

cvxluo Jul 14, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

This comment was marked as outdated.

Uh oh!

Uh oh!

Uh oh!

Uh oh!

This comment was marked as outdated.

Uh oh!

wedamija Jul 16, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

cursor bot left a comment

Choose a reason for hiding this comment

Bug: In-memory Project Platform Not Updated Post-Database Write

Uh oh!

Uh oh!

Uh oh!

cvxluo commented Jul 13, 2025 •

edited

Loading

codecov bot commented Jul 13, 2025 •

edited

Loading

mrduncan Jul 14, 2025 •

edited

Loading

cvxluo Jul 14, 2025 •

edited

Loading